| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 19 Apr 2021 06:40:46 +0000
From: "Alice Guo (OSS)" <alice.guo@....nxp.com>
To: Dominique MARTINET <dominique.martinet@...ark-techno.com>,
"Alice Guo (OSS)" <alice.guo@....nxp.com>
CC: "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
"rafael@...nel.org" <rafael@...nel.org>,
Horia Geanta <horia.geanta@....com>,
Aymen Sghaier <aymen.sghaier@....com>,
"herbert@...dor.apana.org.au" <herbert@...dor.apana.org.au>,
"davem@...emloft.net" <davem@...emloft.net>,
"tony@...mide.com" <tony@...mide.com>,
"geert+renesas@...der.be" <geert+renesas@...der.be>,
"mturquette@...libre.com" <mturquette@...libre.com>,
"sboyd@...nel.org" <sboyd@...nel.org>,
"vkoul@...nel.org" <vkoul@...nel.org>,
"peter.ujfalusi@...il.com" <peter.ujfalusi@...il.com>,
"a.hajda@...sung.com" <a.hajda@...sung.com>,
"narmstrong@...libre.com" <narmstrong@...libre.com>,
"robert.foss@...aro.org" <robert.foss@...aro.org>,
"airlied@...ux.ie" <airlied@...ux.ie>,
"daniel@...ll.ch" <daniel@...ll.ch>,
"khilman@...libre.com" <khilman@...libre.com>,
"tomba@...nel.org" <tomba@...nel.org>,
"jyri.sarha@....fi" <jyri.sarha@....fi>,
"joro@...tes.org" <joro@...tes.org>,
"will@...nel.org" <will@...nel.org>,
"mchehab@...nel.org" <mchehab@...nel.org>,
"ulf.hansson@...aro.org" <ulf.hansson@...aro.org>,
"adrian.hunter@...el.com" <adrian.hunter@...el.com>,
"kishon@...com" <kishon@...com>,
"kuba@...nel.org" <kuba@...nel.org>,
"linus.walleij@...aro.org" <linus.walleij@...aro.org>,
Leo Li <leoyang.li@....com>,
"ssantosh@...nel.org" <ssantosh@...nel.org>,
"matthias.bgg@...il.com" <matthias.bgg@...il.com>,
"edubezval@...il.com" <edubezval@...il.com>,
"j-keerthy@...com" <j-keerthy@...com>,
"balbi@...nel.org" <balbi@...nel.org>,
"linux@...sktech.co.nz" <linux@...sktech.co.nz>,
"stern@...land.harvard.edu" <stern@...land.harvard.edu>,
"wim@...ux-watchdog.org" <wim@...ux-watchdog.org>,
"linux@...ck-us.net" <linux@...ck-us.net>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
"linux-renesas-soc@...r.kernel.org"
<linux-renesas-soc@...r.kernel.org>,
"linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
"dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
"linux-amlogic@...ts.infradead.org"
<linux-amlogic@...ts.infradead.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"iommu@...ts.linux-foundation.org" <iommu@...ts.linux-foundation.org>,
"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
"linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"linux-phy@...ts.infradead.org" <linux-phy@...ts.infradead.org>,
"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
"linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
"linux-staging@...ts.linux.dev" <linux-staging@...ts.linux.dev>,
"linux-mediatek@...ts.infradead.org"
<linux-mediatek@...ts.infradead.org>,
"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
"linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>,
dl-linux-imx <linux-imx@....com>
Subject: RE: [RFC v1 PATCH 1/3] drivers: soc: add support for soc_device_match
returning -EPROBE_DEFER
> -----Original Message-----
> From: Dominique MARTINET <dominique.martinet@...ark-techno.com>
> Sent: 2021年4月19日 12:49
> To: Alice Guo (OSS) <alice.guo@....nxp.com>
> Cc: gregkh@...uxfoundation.org; rafael@...nel.org; Horia Geanta
> <horia.geanta@....com>; Aymen Sghaier <aymen.sghaier@....com>;
> herbert@...dor.apana.org.au; davem@...emloft.net; tony@...mide.com;
> geert+renesas@...der.be; mturquette@...libre.com; sboyd@...nel.org;
> vkoul@...nel.org; peter.ujfalusi@...il.com; a.hajda@...sung.com;
> narmstrong@...libre.com; robert.foss@...aro.org; airlied@...ux.ie;
> daniel@...ll.ch; khilman@...libre.com; tomba@...nel.org; jyri.sarha@....fi;
> joro@...tes.org; will@...nel.org; mchehab@...nel.org;
> ulf.hansson@...aro.org; adrian.hunter@...el.com; kishon@...com;
> kuba@...nel.org; linus.walleij@...aro.org; Roy Pledge <roy.pledge@....com>;
> Leo Li <leoyang.li@....com>; ssantosh@...nel.org; matthias.bgg@...il.com;
> edubezval@...il.com; j-keerthy@...com; balbi@...nel.org;
> linux@...sktech.co.nz; stern@...land.harvard.edu; wim@...ux-watchdog.org;
> linux@...ck-us.net; linux-kernel@...r.kernel.org; linux-crypto@...r.kernel.org;
> linux-omap@...r.kernel.org; linux-renesas-soc@...r.kernel.org;
> linux-clk@...r.kernel.org; dmaengine@...r.kernel.org;
> dri-devel@...ts.freedesktop.org; linux-amlogic@...ts.infradead.org;
> linux-arm-kernel@...ts.infradead.org; iommu@...ts.linux-foundation.org;
> linux-media@...r.kernel.org; linux-mmc@...r.kernel.org;
> netdev@...r.kernel.org; linux-phy@...ts.infradead.org;
> linux-gpio@...r.kernel.org; linuxppc-dev@...ts.ozlabs.org;
> linux-staging@...ts.linux.dev; linux-mediatek@...ts.infradead.org;
> linux-pm@...r.kernel.org; linux-usb@...r.kernel.org;
> linux-watchdog@...r.kernel.org
> Subject: Re: [RFC v1 PATCH 1/3] drivers: soc: add support for soc_device_match
> returning -EPROBE_DEFER
>
> First comment overall for the whole serie:
> Since it is the solution I had suggested when I reported the problem[1] I have no
> qualm on the approach, comments for individual patches follow.
>
> [1] http://lore.kernel.org/r/YGGZJjAxA1IO+/VU@atmark-techno.com
>
>
> Alice Guo (OSS) wrote on Mon, Apr 19, 2021 at 12:27:20PM +0800:
> > From: Alice Guo <alice.guo@....com>
> >
> > In i.MX8M boards, the registration of SoC device is later than caam
> > driver which needs it. Caam driver needs soc_device_match to provide
> > -EPROBE_DEFER when no SoC device is registered and no
> > early_soc_dev_attr.
>
> This patch should be last in the set: you can't have soc_device_match return an
> error before its callers handle it.
>
> > Signed-off-by: Alice Guo <alice.guo@....com>
>
> As the one who reported the problem I would have been appreciated being at
> least added to Ccs... I only happened to notice you posted this by chance.
Sorry. I will Cc you next time.
> There is also not a single Fixes tag -- I believe this commit should have Fixes:
> 7d981405d0fd ("soc: imx8m: change to use platform driver") but I'm not sure
> how such tags should be handled in case of multiple patches fixing something.
I only mentioned "soc: imx8m: change to use platform driver" in cover letter.
If it is acceptable to make such a modification, I will send non-RFC and add Fixes tag.
Best Regards,
Alice
> --
> Dominique
Powered by blists - more mailing lists