netdev - Re: [PATCH net-next 2/3] net: ethernet: mtk_eth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <C076C591-F541-48B3-9750-8F35B4127638@public-files.de>
Date:   Tue, 20 Apr 2021 13:51:07 +0200
From:   Frank Wunderlich <frank-w@...lic-files.de>
To:     Pablo Neira Ayuso <pablo@...filter.org>, netdev@...r.kernel.org
CC:     davem@...emloft.net, kuba@...nel.org, john@...ozen.org,
        nbd@....name, sean.wang@...iatek.com, Mark-MC.Lee@...iatek.com,
        dqfext@...il.com
Subject: Re: [PATCH net-next 2/3] net: ethernet: mtk_eth_soc: missing mutex

Am 18. April 2021 23:11:44 MESZ schrieb Pablo Neira Ayuso <pablo@...filter.org>:
>Patch 2ed37183abb7 ("netfilter: flowtable: separate replace, destroy
>and
>stats to different workqueues") splits the workqueue per event type.
>Add
>a mutex to serialize updates.
>
>Fixes: 502e84e2382d ("net: ethernet: mtk_eth_soc: add flow offloading
>support")
>Reported-by: Frank Wunderlich <frank-w@...lic-files.de>
>Signed-off-by: Pablo Neira Ayuso <pablo@...filter.org>

Hi Pablo,

As far we tested it, the mutex does not avoid the hang. It looks a bit better,but at the end it was fixed by this Patch

https://patchwork.kernel.org/project/linux-mediatek/patch/20210417072905.207032-1-dqfext@gmail.com/

Alex did some tests without the lock here and it still looks stable. So it looks like it is not needed
regards Frank