netdev - Re: [PATCH net-next V2] icmp: ICMPV6: pass RFC 8335 reply messages to ping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 20 Apr 2021 10:20:51 -0500
From:   Andreas Roeseler <andreas.a.roeseler@...il.com>
To:     Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc:     Network Development <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        David Ahern <dsahern@...nel.org>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH net-next V2] icmp: ICMPV6: pass RFC 8335 reply messages
 to ping_rcv

On Tue, 2021-04-13 at 17:51 -0400, Willem de Bruijn wrote:
> On Mon, Apr 12, 2021 at 5:25 PM Andreas Roeseler
> <andreas.a.roeseler@...il.com> wrote:
> > 
> > The current icmp_rcv function drops all unknown ICMP types,
> > including
> > ICMP_EXT_ECHOREPLY (type 43). In order to parse Extended Echo Reply
> > messages, we have
> > to pass these packets to the ping_rcv function, which does not do
> > any
> > other filtering and passes the packet to the designated socket.
> > 
> > Pass incoming RFC 8335 ICMP Extended Echo Reply packets to the
> > ping_rcv
> > handler instead of discarding the packet.
> > 
> > Signed-off-by: Andreas Roeseler <andreas.a.roeseler@...il.com>
> 
> Acked-by: Willem de Bruijn <willemb@...gle.com>
> 
> for future patches: please add reviewers of previous revisions
> directly to the CC:

Please let me know if there is any feedback/comments for this patch