netdev - Re: [PATCH net-next v2 5/6] sfc: ef10: implement ethtool::get_fec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210420112424.364d9235@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 20 Apr 2021 11:24:24 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Edward Cree <ecree.xilinx@...il.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        michael.chan@...adcom.com, saeedm@...dia.com, leon@...nel.org,
        habetsm.xilinx@...il.com, f.fainelli@...il.com, andrew@...n.ch,
        mkubecek@...e.cz, ariela@...dia.com
Subject: Re: [PATCH net-next v2 5/6] sfc: ef10: implement
 ethtool::get_fec_stats

On Tue, 20 Apr 2021 16:13:21 +0100 Edward Cree wrote:
> On 15/04/2021 23:53, Jakub Kicinski wrote:
> > Report what appears to be the standard block counts:
> >  - 30.5.1.1.17 aFECCorrectedBlocks
> >  - 30.5.1.1.18 aFECUncorrectableBlocks
> > 
> > Don't report the per-lane symbol counts, if those really
> > count symbols they are not what the standard calls for
> > (even if symbols seem like the most useful thing to count.)
> > 
> > Fingers crossed that fec_corrected_errors is not in symbols.
> > 
> > Signed-off-by: Jakub Kicinski <kuba@...nel.org>  
> 
> For the record: yes, fec_[un]corrected_errors are counts of
>  FEC codewords, not symbols, so this patch is correct.
> 
> Whereas, the per-lane counts definitely are counting symbols.

Thanks for reviewing!