netdev - Re: [PATCH] ice: set the value of global config lock timeout longer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 20 Apr 2021 22:48:29 +0000
From:   "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>
To:     "liwei.song@...driver.com" <liwei.song@...driver.com>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "Brandeburg, Jesse" <jesse.brandeburg@...el.com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "Venkataramanan, Anirudh" <anirudh.venkataramanan@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ice: set the value of global config lock timeout longer

On Mon, 2021-04-19 at 17:31 +0800, Liwei Song wrote:
> It may need hold Global Config Lock a longer time when download DDP
> package file, extend the timeout value to 5000ms to ensure that
> download can be finished before other AQ command got time to run,
> this will fix the issue below when probe the device, 5000ms is a test
> value that work with both Backplane and BreakoutCable NVM image:
> 
> ice 0000:f4:00.0: VSI 12 failed lan queue config, error ICE_ERR_CFG
> ice 0000:f4:00.0: Failed to delete VSI 12 in FW - error:
> ICE_ERR_AQ_TIMEOUT
> ice 0000:f4:00.0: probe failed due to setup PF switch: -12
> ice: probe of 0000:f4:00.0 failed with error -12

Hi Liwei,

We haven't encountered this issue before. Can you provide some more
info on your setup or how you're coming across this issue?

Perhaps, lspci output and some more of the dmesg log? We'd like to try
to reproduce this so we can invesitgate it further.

Thanks,
Tony

> Signed-off-by: Liwei Song <liwei.song@...driver.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_type.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_type.h
> b/drivers/net/ethernet/intel/ice/ice_type.h
> index 266036b7a49a..8a90c47e337d 100644
> --- a/drivers/net/ethernet/intel/ice/ice_type.h
> +++ b/drivers/net/ethernet/intel/ice/ice_type.h
> @@ -63,7 +63,7 @@ enum ice_aq_res_ids {
>  /* FW update timeout definitions are in milliseconds */
>  #define ICE_NVM_TIMEOUT			180000
>  #define ICE_CHANGE_LOCK_TIMEOUT		1000
> -#define ICE_GLOBAL_CFG_LOCK_TIMEOUT	3000
> +#define ICE_GLOBAL_CFG_LOCK_TIMEOUT	5000
>  
>  enum ice_aq_res_access_type {
>  	ICE_RES_READ = 1,