netdev - Re: [PATCH V2 02/16] net: iosm: irq handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210420.164802.229687091665923532.davem@davemloft.net>
Date:   Tue, 20 Apr 2021 16:48:02 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     m.chetan.kumar@...el.com
Cc:     netdev@...r.kernel.org, linux-wireless@...r.kernel.org,
        johannes@...solutions.net, krishna.c.sudi@...el.com,
        linuxwwan@...el.com
Subject: Re: [PATCH V2 02/16] net: iosm: irq handling

From: M Chetan Kumar <m.chetan.kumar@...el.com>
Date: Tue, 20 Apr 2021 21:42:56 +0530

> 1) Request interrupt vector, frees allocated resource.
> 2) Registers IRQ handler.
> 
> Signed-off-by: M Chetan Kumar <m.chetan.kumar@...el.com>
> ---
> v2: Streamline multiple returns using goto.
> ---
>  drivers/net/wwan/iosm/iosm_ipc_irq.c | 91 ++++++++++++++++++++++++++++
>  drivers/net/wwan/iosm/iosm_ipc_irq.h | 33 ++++++++++
>  2 files changed, 124 insertions(+)
>  create mode 100644 drivers/net/wwan/iosm/iosm_ipc_irq.c
>  create mode 100644 drivers/net/wwan/iosm/iosm_ipc_irq.h
> 
> diff --git a/drivers/net/wwan/iosm/iosm_ipc_irq.c b/drivers/net/wwan/iosm/iosm_ipc_irq.c
> new file mode 100644
> index 000000000000..a3e017604fa4
> --- /dev/null
> +++ b/drivers/net/wwan/iosm/iosm_ipc_irq.c
> @@ -0,0 +1,91 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Copyright (C) 2020-21 Intel Corporation.
> + */
> +
> +#include "iosm_ipc_pcie.h"
> +#include "iosm_ipc_protocol.h"
> +
> +static inline void write_dbell_reg(struct iosm_pcie *ipc_pcie, int irq_n,
> +				   u32 data)

Please do not use inline in foo.c files, let the compiler decide.

Thank you.