netdev - Re: [PATCH] net: ethernet: ravb: Fix release of refclk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3937a792-8985-10c1-b818-af2fbc2241df@gmail.com>
Date:   Wed, 21 Apr 2021 17:25:39 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...il.com>
To:     Adam Ford <aford173@...il.com>, netdev@...r.kernel.org
Cc:     aford@...conembedded.com, "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, Andrew Lunn <andrew@...n.ch>,
        linux-renesas-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: ethernet: ravb: Fix release of refclk

On 4/21/21 5:05 PM, Adam Ford wrote:

> The call to clk_disable_unprepare() can happen before priv is
> initialized.

   This still doesn't make sense for me...

> This means moving clk_disable_unprepare out of
                                         ^ call
> out_release into a new label.
> 
> Fixes: 8ef7adc6beb2 ("net: ethernet: ravb: Enable optional refclk")
> Signed-off-by: Adam Ford <aford173@...il.com>

Reviewed-by: Sergei Shtylyov <sergei.shtylyov@...il.com>


[...]

MBR, Sergei