netdev - Re: [PATCH] ath9k:remove unneeded variable in ath9k_dump_legacy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20210421174610.B4FD1C433F1@smtp.codeaurora.org>
Date:   Wed, 21 Apr 2021 17:46:10 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     zhangkun4jr@....com
Cc:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, ath9k-devel@....qualcomm.com,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Zhang Kun <zhangkun@...rlc.com>
Subject: Re: [PATCH] ath9k:remove unneeded variable in
 ath9k_dump_legacy_btcoex

zhangkun4jr@....com wrote:

> From: Zhang Kun <zhangkun@...rlc.com>
> 
> Remove unneeded variable 'len' in ath9k_dump_legacy_btcoex.
> 
> Signed-off-by: Zhang Kun <zhangkun@...rlc.com>

This fails to compile. Always build check your patches!

In file included from drivers/net/wireless/ath/ath9k/gpio.c:17:
drivers/net/wireless/ath/ath9k/gpio.c: In function 'ath9k_dump_legacy_btcoex':
drivers/net/wireless/ath/ath9k/ath9k.h:763:3: error: 'len' undeclared (first use in this function)
  763 |   len += scnprintf(buf + len, size - len,  \
      |   ^~~
drivers/net/wireless/ath/ath9k/gpio.c:501:2: note: in expansion of macro 'ATH_DUMP_BTCOEX'
  501 |  ATH_DUMP_BTCOEX("Stomp Type", btcoex->bt_stomp_type);
      |  ^~~~~~~~~~~~~~~
drivers/net/wireless/ath/ath9k/ath9k.h:763:3: note: each undeclared identifier is reported only once for each function it appears in
  763 |   len += scnprintf(buf + len, size - len,  \
      |   ^~~
drivers/net/wireless/ath/ath9k/gpio.c:501:2: note: in expansion of macro 'ATH_DUMP_BTCOEX'
  501 |  ATH_DUMP_BTCOEX("Stomp Type", btcoex->bt_stomp_type);
      |  ^~~~~~~~~~~~~~~
make[5]: *** [drivers/net/wireless/ath/ath9k/gpio.o] Error 1
make[4]: *** [drivers/net/wireless/ath/ath9k] Error 2
make[3]: *** [drivers/net/wireless/ath] Error 2
make[2]: *** [drivers/net/wireless] Error 2
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2

Patch set to Changes Requested.

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20210224130356.51444-1-zhangkun4jr@163.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches