netdev - Re: [PATCH rdma-next v2 1/5] RDMA/bnxt_re: Depend on bnxt ethernet driver and not blindly select it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 21 Apr 2021 23:20:28 +0530
From:   Devesh Sharma <devesh.sharma@...adcom.com>
To:     Leon Romanovsky <leon@...nel.org>
Cc:     Doug Ledford <dledford@...hat.com>,
        Jason Gunthorpe <jgg@...dia.com>,
        Leon Romanovsky <leonro@...dia.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        linux-rdma <linux-rdma@...r.kernel.org>,
        Michael Chan <michael.chan@...adcom.com>,
        Naresh Kumar PBS <nareshkumar.pbs@...adcom.com>,
        Netdev <netdev@...r.kernel.org>,
        Selvin Xavier <selvin.xavier@...adcom.com>,
        Somnath Kotur <somnath.kotur@...adcom.com>,
        Sriharsha Basavapatna <sriharsha.basavapatna@...adcom.com>
Subject: Re: [PATCH rdma-next v2 1/5] RDMA/bnxt_re: Depend on bnxt ethernet
 driver and not blindly select it

On Thu, Apr 1, 2021 at 12:27 PM Leon Romanovsky <leon@...nel.org> wrote:
>
> From: Leon Romanovsky <leonro@...dia.com>
>
> The "select" kconfig keyword provides reverse dependency, however it
> doesn't check that selected symbol meets its own dependencies. Usually
> "select" is used for non-visible symbols, so instead of trying to keep
> dependencies in sync with BNXT ethernet driver, simply "depends on" it,
> like Kconfig documentation suggest.
>
> * CONFIG_PCI is already required by BNXT
> * CONFIG_NETDEVICES and CONFIG_ETHERNET are needed to chose BNXT
>
> Signed-off-by: Leon Romanovsky <leonro@...dia.com>
> ---
>  drivers/infiniband/hw/bnxt_re/Kconfig | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/infiniband/hw/bnxt_re/Kconfig b/drivers/infiniband/hw/bnxt_re/Kconfig
> index 0feac5132ce1..6a17f5cdb020 100644
> --- a/drivers/infiniband/hw/bnxt_re/Kconfig
> +++ b/drivers/infiniband/hw/bnxt_re/Kconfig
> @@ -2,9 +2,7 @@
>  config INFINIBAND_BNXT_RE
>         tristate "Broadcom Netxtreme HCA support"
>         depends on 64BIT
> -       depends on ETHERNET && NETDEVICES && PCI && INET && DCB
> -       select NET_VENDOR_BROADCOM
> -       select BNXT
> +       depends on INET && DCB && BNXT
>         help
>           This driver supports Broadcom NetXtreme-E 10/25/40/50 gigabit
>           RoCE HCAs.  To compile this driver as a module, choose M here:
> --
> 2.30.2
>
Acked-By: Devesh Sharma <devesh.sharma@...adcom.com>

-- 
-Regards
Devesh

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4212 bytes)