netdev - Re: [PATCH v2 3/3] net: stmmac: Add RK3566 SoC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d1de806e3989900a8a6477f35dce1575473a8983.camel@collabora.com>
Date:   Wed, 21 Apr 2021 18:06:13 -0300
From:   Ezequiel Garcia <ezequiel@...labora.com>
To:     Johan Jonker <jbx6244@...il.com>, netdev@...r.kernel.org,
        linux-rockchip@...ts.infradead.org
Cc:     Jose Abreu <joabreu@...opsys.com>,
        Heiko Stuebner <heiko@...ech.de>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Peter Geis <pgwipeout@...il.com>,
        Kever Yang <kever.yang@...k-chips.com>,
        David Wu <david.wu@...k-chips.com>, kernel@...labora.com
Subject: Re: [PATCH v2 3/3] net: stmmac: Add RK3566 SoC support

On Wed, 2021-04-21 at 22:49 +0200, Johan Jonker wrote:
> On 4/21/21 10:34 PM, Ezequiel Garcia wrote:
> > From: David Wu <david.wu@...k-chips.com>
> > 
> > Add constants and callback functions for the dwmac present
> > on RK3566 SoCs. As can be seen, the base structure
> > is the same, only registers and the bits in them moved slightly.
> > 
> > The dwmac IP core version v5.1, and so the compatible string
> > is expected to be:
> > 
> >   compatible = "rockchip,rk3566-gmac", "snps,dwmac-4.20a";
> > 
> > Signed-off-by: David Wu <david.wu@...k-chips.com>
> > [Ezequiel: Separate rk3566-gmac support]
> > Signed-off-by: Ezequiel Garcia <ezequiel@...labora.com>
> > ---
> >  .../bindings/net/rockchip-dwmac.txt           |  1 +
> >  .../net/ethernet/stmicro/stmmac/dwmac-rk.c    | 89 +++++++++++++++++++
> >  2 files changed, 90 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.txt b/Documentation/devicetree/bindings/net/rockchip-dwmac.txt
> > index 3b71da7e8742..3bd4bbcd6c65 100644
> > --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.txt
> > +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.txt
> > @@ -12,6 +12,7 @@ Required properties:
> >     "rockchip,rk3366-gmac": found on RK3366 SoCs
> >     "rockchip,rk3368-gmac": found on RK3368 SoCs
> >     "rockchip,rk3399-gmac": found on RK3399 SoCs
> 
> > +   "rockchip,rk3566-gmac", "snps,dwmac-4.20a": found on RK3566 SoCs
> 
> This is still a text document.
> rob+dt has now scripts that check for undocumented compatibility
> strings, so first convert rockchip-dwmac.txt to YAML and then add this
> in a separated patch.
> 

Is it a showstopper to convert devicetree bindings to YAML, for driver submission?

Thanks,
Ezequiel