netdev - Re: [PATCH net v2] igb: Fix XDP with PTP enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <874kg0b0x1.fsf@kurt>
Date:   Wed, 21 Apr 2021 08:35:06 +0200
From:   Kurt Kanzenbach <kurt@...utronix.de>
To:     "Nguyen\, Anthony L" <anthony.l.nguyen@...el.com>,
        "davem\@davemloft.net" <davem@...emloft.net>,
        "kuba\@kernel.org" <kuba@...nel.org>,
        "Brandeburg\, Jesse" <jesse.brandeburg@...el.com>
Cc:     "bigeasy\@linutronix.de" <bigeasy@...utronix.de>,
        "daniel\@iogearbox.net" <daniel@...earbox.net>,
        "bpf\@vger.kernel.org" <bpf@...r.kernel.org>,
        "ast\@kernel.org" <ast@...nel.org>,
        "hawk\@kernel.org" <hawk@...nel.org>,
        "lorenzo\@kernel.org" <lorenzo@...nel.org>,
        "john.fastabend\@gmail.com" <john.fastabend@...il.com>,
        "alexander.duyck\@gmail.com" <alexander.duyck@...il.com>,
        "ilias.apalodimas\@linaro.org" <ilias.apalodimas@...aro.org>,
        "richardcochran\@gmail.com" <richardcochran@...il.com>,
        "netdev\@vger.kernel.org" <netdev@...r.kernel.org>,
        "sven.auhagen\@voleatech.de" <sven.auhagen@...eatech.de>,
        "intel-wired-lan\@lists.osuosl.org" 
        <intel-wired-lan@...ts.osuosl.org>
Subject: Re: [PATCH net v2] igb: Fix XDP with PTP enabled

>> +		/* pull rx packet timestamp if available */
>> +		if (igb_test_staterr(rx_desc, E1000_RXDADV_STAT_TSIP))
>> {
>> +			timestamp = igb_ptp_rx_pktstamp(rx_ring-
>> >q_vector,
>> +							pktbuf);
>
> The timestamp should be checked for failure and not adjust these values
> if the timestamp was invalid.

OK. I'll adjust it.

Thanks,
Kurt

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)