netdev - Re: [PATCH 1/2] net: sit: Unregister catch-all devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cb785bdd-6389-e980-5d72-4720e08834d1@6wind.com>
Date:   Wed, 21 Apr 2021 10:33:09 +0200
From:   Nicolas Dichtel <nicolas.dichtel@...nd.com>
To:     Hristo Venev <hristo@...ev.name>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] net: sit: Unregister catch-all devices

Le 12/04/2021 à 19:41, Hristo Venev a écrit :
> A sit interface created without a local or a remote address is linked
> into the `sit_net::tunnels_wc` list of its original namespace. When
> deleting a network namespace, delete the devices that have been moved.
> 
> The following script triggers a null pointer dereference if devices
> linked in a deleted `sit_net` remain:
> 
>     for i in `seq 1 30`; do
>         ip netns add ns-test
>         ip netns exec ns-test ip link add dev veth0 type veth peer veth1
>         ip netns exec ns-test ip link add dev sit$i type sit dev veth0
>         ip netns exec ns-test ip link set dev sit$i netns $$
>         ip netns del ns-test
>     done
>     for i in `seq 1 30`; do
>         ip link del dev sit$i
>     done
> 
> Fixes: 5e6700b3bf98f ("sit: add support of x-netns")
> Signed-off-by: Hristo Venev <hristo@...ev.name>


Thank you for your patches.
Please, think of putting original author in CC when you send a fix ;-)


Regards,
Nicolas