netdev - Re: [PATCH 1/2] net: phy: marvell: fix m88e1011_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YIFsaoxmn3mC8VgH@lunn.ch>
Date:   Thu, 22 Apr 2021 14:30:34 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Maxim Kochetkov <fido_max@...ox.ru>
Cc:     netdev@...r.kernel.org, hkallweit1@...il.com,
        linux@...linux.org.uk, davem@...emloft.net, kuba@...nel.org,
        f.fainelli@...il.com
Subject: Re: [PATCH 1/2] net: phy: marvell: fix m88e1011_set_downshift

On Thu, Apr 22, 2021 at 01:46:43PM +0300, Maxim Kochetkov wrote:
> Changing downshift params without software reset has no effect,
> so call genphy_soft_reset() after change downshift params.
> 
> As the datasheet says:
> Changes to these bits are disruptive to the normal operation therefore,
> any changes to these registers must be followed by software reset
> to take effect.
> 
> Fixes: 911af5e149bb ("net: phy: marvell: fix downshift function naming")
> Signed-off-by: Maxim Kochetkov <fido_max@...ox.ru>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew