netdev - Re: [PATCH v2 net-next 2/9] net: phy: Add support for LAN937x T1 phy driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YIFv9Wcp94395Hbb@lunn.ch>
Date:   Thu, 22 Apr 2021 14:45:41 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Prasanna Vengateshan <prasanna.vengateshan@...rochip.com>
Cc:     netdev@...r.kernel.org, olteanv@...il.com, robh+dt@...nel.org,
        UNGLinuxDriver@...rochip.com, hkallweit1@...il.com,
        linux@...linux.org.uk, davem@...emloft.net, kuba@...nel.org,
        linux-kernel@...r.kernel.org, vivien.didelot@...il.com,
        f.fainelli@...il.com, devicetree@...r.kernel.org
Subject: Re: [PATCH v2 net-next 2/9] net: phy: Add support for LAN937x T1 phy
 driver

> +#define PORT_T1_PHY_RESET	BIT(15)
> +#define PORT_T1_PHY_LOOPBACK	BIT(14)
> +#define PORT_T1_SPEED_100MBIT	BIT(13)
> +#define PORT_T1_POWER_DOWN	BIT(11)
> +#define PORT_T1_ISOLATE	BIT(10)
> +#define PORT_T1_FULL_DUPLEX	BIT(8)

These appear to be standard BMCR_ values. Please don't define your
own.

> +
> +#define REG_PORT_T1_PHY_BASIC_STATUS 0x01
> +
> +#define PORT_T1_MII_SUPPRESS_CAPABLE	BIT(6)
> +#define PORT_T1_LINK_STATUS		BIT(2)
> +#define PORT_T1_EXTENDED_CAPABILITY	BIT(0)
> +
> +#define REG_PORT_T1_PHY_ID_HI 0x02
> +#define REG_PORT_T1_PHY_ID_LO 0x03

MII_PHYSID1 and MII_PHYSID2

Please go through all these #defines and replace them with the
standard ones Linux provides. You are obfusticating the code by not
using what people already know.

      Andrew