netdev - Re: [PATCH net-next v2] net: wwan: core: Return poll error in case of port removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YIGQEpbJvcOz2/VI@unreal>
Date:   Thu, 22 Apr 2021 18:02:42 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Loic Poulain <loic.poulain@...aro.org>
Cc:     kuba@...nel.org, davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2] net: wwan: core: Return poll error in case
 of port removal

On Thu, Apr 22, 2021 at 04:06:01PM +0200, Loic Poulain wrote:
> Ensure that the poll system call returns proper error flags when port
> is removed (nullified port ops), allowing user side to properly fail,
> without further read or write.
> 
> Fixes: 9a44c1cc6388 ("net: Add a WWAN subsystem")
> Signed-off-by: Loic Poulain <loic.poulain@...aro.org>
> ---
>  v2: get rid of useless locking for accessing port->ops
> 
>  drivers/net/wwan/wwan_core.c | 2 ++
>  1 file changed, 2 insertions(+)
> 

Please take my ROB with a grain of salt.

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...dia.com>