netdev - Re: [PATCH v2 bpf-next 02/17] bpftool: dump more info about DATASEC members

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <35749ecd-39aa-f09a-8eec-7afdbecc425f@fb.com>
Date:   Wed, 21 Apr 2021 20:09:31 -0700
From:   Yonghong Song <yhs@...com>
To:     Andrii Nakryiko <andrii@...nel.org>, <bpf@...r.kernel.org>,
        <netdev@...r.kernel.org>, <ast@...com>, <daniel@...earbox.net>
CC:     <kernel-team@...com>
Subject: Re: [PATCH v2 bpf-next 02/17] bpftool: dump more info about DATASEC
 members



On 4/16/21 1:23 PM, Andrii Nakryiko wrote:
> Dump succinct information for each member of DATASEC: its kinds and name. This
> is extremely helpful to see at a quick glance what is inside each DATASEC of

This is indeed very useful and user friendly!

> a given BTF. Without this, one has to jump around BTF data to just find out
> the name of a VAR or FUNC. DATASEC's var_secinfo member is special in that
> regard because it doesn't itself contain the name of the member, delegating
> that to the referenced VAR and FUNC kinds. Other kinds, like
> STRUCT/UNION/FUNC/ENUM, encode member names directly and thus are clearly
> identifiable in BTF dump.
> 
> The new output looks like this:
> 
> [35] DATASEC '.bss' size=0 vlen=6
>          type_id=8 offset=0 size=4 (VAR 'input_bss1')
>          type_id=13 offset=0 size=4 (VAR 'input_bss_weak')
>          type_id=16 offset=0 size=4 (VAR 'output_bss1')
>          type_id=17 offset=0 size=4 (VAR 'output_data1')
>          type_id=18 offset=0 size=4 (VAR 'output_rodata1')
>          type_id=20 offset=0 size=8 (VAR 'output_sink1')
> [36] DATASEC '.data' size=0 vlen=2
>          type_id=9 offset=0 size=4 (VAR 'input_data1')
>          type_id=14 offset=0 size=4 (VAR 'input_data_weak')
> [37] DATASEC '.kconfig' size=0 vlen=2
>          type_id=25 offset=0 size=4 (VAR 'LINUX_KERNEL_VERSION')
>          type_id=28 offset=0 size=1 (VAR 'CONFIG_BPF_SYSCALL')
> [38] DATASEC '.ksyms' size=0 vlen=1
>          type_id=30 offset=0 size=1 (VAR 'bpf_link_fops')
> [39] DATASEC '.rodata' size=0 vlen=2
>          type_id=12 offset=0 size=4 (VAR 'input_rodata1')
>          type_id=15 offset=0 size=4 (VAR 'input_rodata_weak')
> [40] DATASEC 'license' size=0 vlen=1
>          type_id=24 offset=0 size=4 (VAR 'LICENSE')
> 
> Signed-off-by: Andrii Nakryiko <andrii@...nel.org>

Acked-by: Yonghong Song <yhs@...com>