netdev - Re: [RFC net-next] net: stmmac: should not modify RX descriptor when STMMAC resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2cf60306-e2b9-cc24-359c-774c9d339074@gmail.com>
Date:   Thu, 22 Apr 2021 09:12:16 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Joakim Zhang <qiangqing.zhang@....com>,
        Jon Hunter <jonathanh@...dia.com>,
        "peppe.cavallaro@...com" <peppe.cavallaro@...com>,
        "alexandre.torgue@...s.st.com" <alexandre.torgue@...s.st.com>,
        "joabreu@...opsys.com" <joabreu@...opsys.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "mcoquelin.stm32@...il.com" <mcoquelin.stm32@...il.com>,
        "andrew@...n.ch" <andrew@...n.ch>
Cc:     dl-linux-imx <linux-imx@....com>,
        "treding@...dia.com" <treding@...dia.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [RFC net-next] net: stmmac: should not modify RX descriptor when
 STMMAC resume



On 4/21/2021 9:53 PM, Joakim Zhang wrote:
> 
>> -----Original Message-----
>> From: Jon Hunter <jonathanh@...dia.com>
>> Sent: 2021年4月20日 21:34
>> To: Joakim Zhang <qiangqing.zhang@....com>; peppe.cavallaro@...com;
>> alexandre.torgue@...s.st.com; joabreu@...opsys.com;
>> davem@...emloft.net; kuba@...nel.org; mcoquelin.stm32@...il.com;
>> andrew@...n.ch; f.fainelli@...il.com
>> Cc: dl-linux-imx <linux-imx@....com>; treding@...dia.com;
>> netdev@...r.kernel.org
>> Subject: Re: [RFC net-next] net: stmmac: should not modify RX descriptor when
>> STMMAC resume
>>
>>
>>
>> On 20/04/2021 02:49, Joakim Zhang wrote:
>>
>> ...
>>
>>>> I have tested this patch, but unfortunately the board still fails to
>>>> resume correctly. So it appears to suffer with the same issue we saw
>>>> on the previous implementation.
>>>
>>> Could I double check with you? Have you reverted Commit 9c63faaa931e
>> ("net: stmmac: re-init rx buffers when mac resume back") and then apply above
>> patch to do the test?
>>>
>>> If yes, you still saw the same issue with Commit 9c63faaa931e? Let's recall
>> the problem, system suspended, but system hang when STMMAC resume back,
>> right?
>>
>>
>> I tested your patch on top of next-20210419 which has Thierry's revert of
>> 9c63faaa931e. So yes this is reverted. Unfortunately, with this change
>> resuming from suspend still does not work.
> 
> 
> Hi Jakub, Andrew,
> 
> Could you please help review this patch? It's really beyond my comprehension, why this patch would affect Tegra186 Jetson TX2 board?
> Thanks a lot!

What does the resumption failure looks like? Does the stmmac driver
successfully resume from your suspend state, but there is no network
traffic? Do you have a log by any chance?

Is power to the Ethernet MAC turned off in this suspend state, in which
case could we be missing an essential register programming stage?
-- 
Florian