netdev - Re: [PATCH v2 bpf-next 08/17] libbpf: make few internal helpers available outside of libbpf.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzY69Mm4Sz85cRXJTReKba6BDD5NrSGnEkisAYsaaodCuw@mail.gmail.com>
Date:   Thu, 22 Apr 2021 11:18:11 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Yonghong Song <yhs@...com>
Cc:     Andrii Nakryiko <andrii@...nel.org>, bpf <bpf@...r.kernel.org>,
        Networking <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH v2 bpf-next 08/17] libbpf: make few internal helpers
 available outside of libbpf.c

On Thu, Apr 22, 2021 at 9:19 AM Yonghong Song <yhs@...com> wrote:
>
>
>
> On 4/16/21 1:23 PM, Andrii Nakryiko wrote:
> > Make skip_mods_and_typedefs(), btf_kind_str(), and btf_func_linkage() helpers
> > available outside of libbpf.c, to be used by static linker code.
> >
> > Also do few cleanups (error code fixes, comment clean up, etc) that don't
> > deserve their own commit.
>
> In general, a separate commit will be good. In this case, we already
> have quite some commits in the patch set. So it should be okay
> to add some minor cleanups here.
>

Yeah, that and it always feels like those minor clean ups that you
only ever discover as you work on some bigger feature would be a waste
of everyone's time, if submitted as individual patches.

> >
> > Signed-off-by: Andrii Nakryiko <andrii@...nel.org>
>
> Acked-by: Yonghong Song <yhs@...com>