netdev - Re: [net-next 6/6] can: mcp251xfd: mcp251xfd_regmap_crc_read(): work around broken CRC on TBC register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a46b95e3-4238-a930-6de3-360f86beaf52@pengutronix.de>
Date:   Thu, 22 Apr 2021 09:18:54 +0200
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Drew Fustini <drew@...gleboard.org>
Cc:     netdev@...r.kernel.org, linux-can@...r.kernel.org,
        kernel@...gutronix.de, Manivannan Sadhasivam <mani@...nel.org>,
        Will C <will@...china.cc>,
        Thomas Kopp <thomas.kopp@...rochip.com>
Subject: Re: [net-next 6/6] can: mcp251xfd: mcp251xfd_regmap_crc_read(): work
 around broken CRC on TBC register

On 4/21/21 9:58 PM, Drew Fustini wrote:
> I am encountering similar error with the 5.10 raspberrypi kernel on
> RPi 4 with MCP2518FD:
> 
>   mcp251xfd spi0.0 can0: CRC read error at address 0x0010 (length=4,
> data=00 ad 58 67, CRC=0xbbfd) retrying

What's the situation you see these errors?

I'm not particular happy with that patch, as it only works around that one
particular bit flip issue. If you really hammer the register, the driver will
still notice CRC errors that can be explained by other bits flipping. Consider
this as the first order approximation of a higher order problem :) - the root
cause is still unknown.

> Would it be possible for you to pull these patches into a v5.10 branch
> in your linux-rpi repo [1]?

Here you are:

https://github.com/marckleinebudde/linux-rpi/tree/v5.10-rpi/backport-performance-improvements

I've included the UINC performance enhancements, too. The branch is compiled
tested only, though. I'll send a pull request to the rpi kernel after I've
testing feedback from you.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |



Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)