netdev - Re: [PATCH ethtool-next 6/7] netlink: add support for standard stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YIFEu5cqJmI+4NGv@shredder.lan>
Date:   Thu, 22 Apr 2021 12:41:15 +0300
From:   Ido Schimmel <idosch@...sch.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     mkubecek@...e.cz, netdev@...r.kernel.org
Subject: Re: [PATCH ethtool-next 6/7] netlink: add support for standard stats

On Mon, Apr 19, 2021 at 05:31:11PM -0700, Jakub Kicinski wrote:
> Add support for standard-based stats.
> 
> Unlike ethtool -S eth0 the new stats should be allow cross-vendor
> compatibility. The interface depends on bitsets and is rather simple.

[...]

> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Tested-by: Ido Schimmel <idosch@...dia.com>

One comment below

[...]

> diff --git a/netlink/stats.c b/netlink/stats.c
> new file mode 100644
> index 000000000000..e7e69f002cd5
> --- /dev/null
> +++ b/netlink/stats.c
> @@ -0,0 +1,264 @@
> +/*
> + * stats.c - netlink implementation of stats
> + *
> + * Implementation of "ethtool -S <dev> <types>" and

and ?

> + */