netdev - Re: [PATCH 1/3 net-next v3] net: ethernet: ixp4xx: Add DT bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 23 Apr 2021 16:49:19 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        Zoltan HERPAI <wigyori@...0.hu>,
        Raylynn Knight <rayknight@...com>, devicetree@...r.kernel.org
Subject: Re: [PATCH 1/3 net-next v3] net: ethernet: ixp4xx: Add DT bindings

On Fri, Apr 23, 2021 at 10:22:06AM +0200, Linus Walleij wrote:
> This adds device tree bindings for the IXP4xx ethernet
> controller with optional MDIO bridge.

Hi Linus

That optional MDIO bus sentence is important here. I think it would be
good to give examples for say IXP43x, where the MDIO bus is on NPE-C,
and the phy-handles point from one Ethernet device in the device tree
to the other. It is not unknown, but it is unusual, so giving an
example is good.

Also, looking at the unmodified driver, there is the global variable
mdio_bus. This should contain the one MDIO bus for the cluster. With
the C code, it should be impossible for multiple devices to
instantiate an MDIO bus. But with device tree, is that still true?
Should there be validation that only one device has an MDIO bus in its
device tree?

       Andrew