netdev - Re: [PATCH net-next v6 03/10] net: dsa: microchip: ksz8795: move register offsets and shifts to separate struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 24 Apr 2021 17:43:10 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Oleksij Rempel <o.rempel@...gutronix.de>
Cc:     Woojung Huh <woojung.huh@...rochip.com>,
        UNGLinuxDriver@...rochip.com,
        Florian Fainelli <f.fainelli@...il.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Michael Grzeschik <m.grzeschik@...gutronix.de>,
        kernel@...gutronix.de, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Russell King <linux@...linux.org.uk>
Subject: Re: [PATCH net-next v6 03/10] net: dsa: microchip: ksz8795: move
 register offsets and shifts to separate struct

>  static void ksz8_r_mib_cnt(struct ksz_device *dev, int port, u16 addr, u64 *cnt)
>  {
> +	struct ksz8 *ksz8 = dev->priv;
> +	const u32 *masks = ksz8->masks;
> +	const u8 *regs = ksz8->regs;

Reverse christmas tree.

>  	u16 ctrl_addr;
>  	u32 data;
>  	u8 check;
> @@ -150,6 +204,9 @@ static void ksz8_r_mib_cnt(struct ksz_device *dev, int port, u16 addr, u64 *cnt)
>  static void ksz8_r_mib_pkt(struct ksz_device *dev, int port, u16 addr,
>  			   u64 *dropped, u64 *cnt)
>  {
> +	struct ksz8 *ksz8 = dev->priv;
> +	const u32 *masks = ksz8->masks;
> +	const u8 *regs = ksz8->regs;

Reverse christmas tree.


>  static void ksz8_w_table(struct ksz_device *dev, int table, u16 addr, u64 data)
>  {
> +	struct ksz8 *ksz8 = dev->priv;
> +	const u8 *regs = ksz8->regs;

...

>  static int ksz8_valid_dyn_entry(struct ksz_device *dev, u8 *data)
>  {
> +	struct ksz8 *ksz8 = dev->priv;
> +	const u32 *masks = ksz8->masks;
> +	const u8 *regs = ksz8->regs;
>  	int timeout = 100;

Please fix them all.

Once you have fixed them, you can add my Reviewed-by.

     Andrew