[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210425120951.q42w5ue3ihuxwigf@pengutronix.de>
Date: Sun, 25 Apr 2021 14:09:51 +0200
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Vincent MAILHOL <mailhol.vincent@...adoo.fr>
Cc: Erik Flodin <erik@...din.me>,
Oliver Hartkopp <socketcan@...tkopp.net>,
"David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>,
linux-can <linux-can@...r.kernel.org>,
netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] can: proc: fix rcvlist_* header alignment on 64-bit
system
On 25.04.2021 21:05:41, Vincent MAILHOL wrote:
> On Sun. 25 Apr 2021 at 20:40, Erik Flodin <erik@...din.me> wrote:
> >
> > None of these versions are really grep friendly though. If that is
> > needed, a third variant with two full strings can be used instead.
> > Just let me know which one that's preferred.
>
> Out of all the propositions, my favorite is the third variant
> with two full strings. It is optimal in terms of computing
> time (not that this is a bottleneck...), it can be grepped and
> the source code is easy to understand.
+1
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists