netdev - Re: [PATCH V2 net] net: stmmac: fix MAC WoL unwork if PHY doesn't support WoL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YIa6hnmYhOAOyZLY@lunn.ch>
Date:   Mon, 26 Apr 2021 15:05:10 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Joakim Zhang <qiangqing.zhang@....com>
Cc:     peppe.cavallaro@...com, alexandre.torgue@...com,
        joabreu@...opsys.com, davem@...emloft.net, kuba@...nel.org,
        f.fainelli@...il.com, Jisheng.Zhang@...aptics.com,
        netdev@...r.kernel.org, linux-imx@....com
Subject: Re: [PATCH V2 net] net: stmmac: fix MAC WoL unwork if PHY doesn't
 support WoL

> +	if (wol->wolopts & WAKE_PHY) {
> +		int ret = phylink_ethtool_set_wol(priv->phylink, wol);

This is wrong. No PHY actually implements WAKE_PHY.

What PHYs do implement is WAKE_MAGIC, WAKE_MAGICSEC, WAKE_UCAST, and
WAKE_BCAST. So there is a clear overlap with what the MAC can do.

So you need to decide which is going to provide each of these wakeups,
the MAC or the PHY, and make sure only one does the actual
implementation.

	Andrew