netdev - Re: [PATCH] bonding/alb: return -ENOMEM when kmalloc failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <58eb44800ec3aaafa0f3a88a6d046ac85aaa02fe.camel@perches.com>
Date:   Mon, 26 Apr 2021 06:53:12 -0700
From:   Joe Perches <joe@...ches.com>
To:     Yang Li <yang.lee@...ux.alibaba.com>, j.vosburgh@...il.com
Cc:     vfalico@...il.com, andy@...yhouse.net, davem@...emloft.net,
        kuba@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bonding/alb: return -ENOMEM when kmalloc failed

On Mon, 2021-04-26 at 17:33 +0800, Yang Li wrote:
> The driver is using -1 instead of the -ENOMEM defined macro to
> specify that a buffer allocation failed. Using the correct error
> code is more intuitive.
> 
> Smatch tool warning:
> drivers/net/bonding/bond_alb.c:850 rlb_initialize() warn: returning -1
> instead of -ENOMEM is sloppy
> 
> No functional change, just more standardized.
[]
> diff --git a/drivers/net/bonding/bond_alb.c b/drivers/net/bonding/bond_alb.c
[]
> @@ -847,7 +847,7 @@ static int rlb_initialize(struct bonding *bond)
>  
> 
>  	new_hashtbl = kmalloc(size, GFP_KERNEL);
>  	if (!new_hashtbl)
> -		return -1;
> +		return -ENOMEM;
>  
> 
>  	spin_lock_bh(&bond->mode_lock);
>  
> 

Perhaps the bond_alb_initialize call here which uses the return
value from this function:

drivers/net/bonding/bond_main.c:                if (bond_alb_initialize(bond, (BOND_MODE(bond) == BOND_MODE_ALB)))
drivers/net/bonding/bond_main.c-                        return -ENOMEM;

should use a store/test/return style instead of a fixed value return.

						res = bond_alb_initialize(bond, BOND_MODE(bond) == BOND_MODE_ALB);
						if (res < 0)
							return res;