netdev - Re: [PATCH net v2] igb: Fix XDP with PTP enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <871rax9loz.fsf@kurt>
Date:   Mon, 26 Apr 2021 16:15:08 +0200
From:   Kurt Kanzenbach <kurt@...utronix.de>
To:     Tyler S <tylerjstachecki@...il.com>
Cc:     alexander.duyck@...il.com, anthony.l.nguyen@...el.com,
        ast@...nel.org, bigeasy@...utronix.de, bpf@...r.kernel.org,
        daniel@...earbox.net, davem@...emloft.net, hawk@...nel.org,
        ilias.apalodimas@...aro.org, intel-wired-lan@...ts.osuosl.org,
        jesse.brandeburg@...el.com, john.fastabend@...il.com,
        kuba@...nel.org, lorenzo@...nel.org, netdev@...r.kernel.org,
        richardcochran@...il.com, sven.auhagen@...eatech.de,
        Maciej Fijalkowski <maciej.fijalkowski@...el.com>
Subject: Re: [PATCH net v2] igb: Fix XDP with PTP enabled

On Sun Apr 25 2021, Tyler S wrote:
> Thanks for this work; I was having trouble using XDP on my I354 NIC until this.
>
> Hopefully I have not err'd backporting it to 5.10 -- but I'm seeing
> jumbo frames dropped after applying this (though as previously
> mentioned, non-skb/full driver XDP programs do now work).
>
> Looking at the code, I'm not sure why that is.

I'm also not sure, yet.

Can you try with version 3 of this patch [1] and see if there are still
issues with jumbo frames? Can you also share the backported patch for
v5.10?

Thanks,
Kurt

[1] - https://lkml.kernel.org/netdev/20210422052617.17267-1-kurt@linutronix.de/

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)