netdev - Re: [PATCH v2 net-next 1/9] dt-bindings: net: dsa: dt bindings for microchip lan937x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 26 Apr 2021 09:04:49 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Prasanna Vengateshan <prasanna.vengateshan@...rochip.com>,
        Rob Herring <robh@...nel.org>
Cc:     andrew@...n.ch, netdev@...r.kernel.org, olteanv@...il.com,
        UNGLinuxDriver@...rochip.com, hkallweit1@...il.com,
        linux@...linux.org.uk, davem@...emloft.net, kuba@...nel.org,
        linux-kernel@...r.kernel.org, vivien.didelot@...il.com,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v2 net-next 1/9] dt-bindings: net: dsa: dt bindings for
 microchip lan937x

On 4/25/21 9:05 PM, Prasanna Vengateshan wrote:
>>> +          port@4 {
>>> +            reg = <4>;
>>> +            phy-mode = "rgmii";
>>> +            ethernet = <&ethernet>;
>>
>> You are missing 'ethernet' label.
> This is the cpu port and label is not used anywhere. i received this feedback in
> last patch version. 

Your example of a CPU port node is valid here, we need an 'ethernet'
phandle to know this is a CPU port, otherwise it is just a regular
user-facing port.
-- 
Florian