| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20210426170411.1789186-8-tobias@waldekranz.com>
Date: Mon, 26 Apr 2021 19:04:09 +0200
From: Tobias Waldekranz <tobias@...dekranz.com>
To: davem@...emloft.net, kuba@...nel.org
Cc: andrew@...n.ch, vivien.didelot@...il.com, f.fainelli@...il.com,
olteanv@...il.com, roopa@...dia.com, nikolay@...dia.com,
jiri@...nulli.us, idosch@...sch.org, stephen@...workplumber.org,
netdev@...r.kernel.org, bridge@...ts.linux-foundation.org
Subject: [RFC net-next 7/9] net: dsa: mv88e6xxx: Allocate a virtual DSA port for each bridge
In the near future we want to offload transmission of both unicasts
and multicasts from a bridge by sending a single FORWARD and use the
switches' config to determine the destination(s). Much in the same way
as we have already relied on them to do between user ports in the
past.
As isolation between bridges must still be maintained, we need to pass
an identifier in the DSA tag that the switches can use to determine
the set of physical ports that make up a particular flooding domain.
Therefore: allocate a DSA device/port tuple that is not used by any
physical device to each bridge we are offloading. We can then in
upcoming changes use this tuple to setup cross-chip port based VLANs
to restrict the set of valid egress ports to only contain the ports
that are offloading the same bridge.
Signed-off-by: Tobias Waldekranz <tobias@...dekranz.com>
---
drivers/net/dsa/mv88e6xxx/Makefile | 1 +
drivers/net/dsa/mv88e6xxx/chip.c | 11 +++
drivers/net/dsa/mv88e6xxx/dst.c | 127 +++++++++++++++++++++++++++++
drivers/net/dsa/mv88e6xxx/dst.h | 12 +++
include/net/dsa.h | 5 ++
5 files changed, 156 insertions(+)
create mode 100644 drivers/net/dsa/mv88e6xxx/dst.c
create mode 100644 drivers/net/dsa/mv88e6xxx/dst.h
diff --git a/drivers/net/dsa/mv88e6xxx/Makefile b/drivers/net/dsa/mv88e6xxx/Makefile
index c8eca2b6f959..20e00695b28d 100644
--- a/drivers/net/dsa/mv88e6xxx/Makefile
+++ b/drivers/net/dsa/mv88e6xxx/Makefile
@@ -2,6 +2,7 @@
obj-$(CONFIG_NET_DSA_MV88E6XXX) += mv88e6xxx.o
mv88e6xxx-objs := chip.o
mv88e6xxx-objs += devlink.o
+mv88e6xxx-objs += dst.o
mv88e6xxx-objs += global1.o
mv88e6xxx-objs += global1_atu.o
mv88e6xxx-objs += global1_vtu.o
diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
index eca285aaf72f..06ef654472b7 100644
--- a/drivers/net/dsa/mv88e6xxx/chip.c
+++ b/drivers/net/dsa/mv88e6xxx/chip.c
@@ -33,6 +33,7 @@
#include "chip.h"
#include "devlink.h"
+#include "dst.h"
#include "global1.h"
#include "global2.h"
#include "hwtstamp.h"
@@ -2371,6 +2372,10 @@ static int mv88e6xxx_port_bridge_join(struct dsa_switch *ds, int port,
struct mv88e6xxx_chip *chip = ds->priv;
int err;
+ err = mv88e6xxx_dst_bridge_join(ds->dst, br);
+ if (err)
+ return err;
+
mv88e6xxx_reg_lock(chip);
err = mv88e6xxx_bridge_map(chip, br);
mv88e6xxx_reg_unlock(chip);
@@ -2388,6 +2393,8 @@ static void mv88e6xxx_port_bridge_leave(struct dsa_switch *ds, int port,
mv88e6xxx_port_vlan_map(chip, port))
dev_err(ds->dev, "failed to remap in-chip Port VLAN\n");
mv88e6xxx_reg_unlock(chip);
+
+ mv88e6xxx_dst_bridge_leave(ds->dst, br);
}
static int mv88e6xxx_crosschip_bridge_join(struct dsa_switch *ds,
@@ -3027,6 +3034,10 @@ static int mv88e6xxx_setup(struct dsa_switch *ds)
mv88e6xxx_reg_lock(chip);
+ err = mv88e6xxx_dst_add_chip(chip);
+ if (err)
+ goto unlock;
+
if (chip->info->ops->setup_errata) {
err = chip->info->ops->setup_errata(chip);
if (err)
diff --git a/drivers/net/dsa/mv88e6xxx/dst.c b/drivers/net/dsa/mv88e6xxx/dst.c
new file mode 100644
index 000000000000..399a818063bf
--- /dev/null
+++ b/drivers/net/dsa/mv88e6xxx/dst.c
@@ -0,0 +1,127 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * mv88e6xxx global DSA switch tree state
+ */
+
+#include <linux/bitmap.h>
+#include <linux/dsa/mv88e6xxx.h>
+#include <linux/list.h>
+#include <linux/module.h>
+#include <linux/netdevice.h>
+#include <net/dsa.h>
+
+#include "chip.h"
+#include "dst.h"
+#include "global2.h"
+
+struct mv88e6xxx_br {
+ struct list_head list;
+
+ struct net_device *brdev;
+ u8 dev;
+ u8 port;
+};
+
+struct mv88e6xxx_dst {
+ struct list_head bridges;
+
+ DECLARE_BITMAP(busy_ports, MV88E6XXX_MAX_PVT_ENTRIES);
+
+#define DEV_PORT_TO_BIT(_dev, _port) \
+ ((_dev) * MV88E6XXX_MAX_PVT_PORTS + (_port))
+#define DEV_FROM_BIT(_bit) ((_bit) / MV88E6XXX_MAX_PVT_PORTS)
+#define PORT_FROM_BIT(_bit) ((_bit) % (MV88E6XXX_MAX_PVT_PORTS))
+};
+
+int mv88e6xxx_dst_bridge_join(struct dsa_switch_tree *dst,
+ struct net_device *brdev)
+{
+ struct mv88e6xxx_dst *mvdst = dst->priv;
+ struct mv88e6xxx_br *mvbr;
+ unsigned int bit;
+
+ list_for_each_entry(mvbr, &mvdst->bridges, list) {
+ if (mvbr->brdev == brdev)
+ return 0;
+ }
+
+ bit = find_first_zero_bit(mvdst->busy_ports,
+ MV88E6XXX_MAX_PVT_ENTRIES);
+
+ if (bit >= MV88E6XXX_MAX_PVT_ENTRIES) {
+ pr_err("Unable to allocate virtual port for %s in DSA tree %d\n",
+ netdev_name(brdev), dst->index);
+ return -ENOSPC;
+ }
+
+ mvbr = kzalloc(sizeof(*mvbr), GFP_KERNEL);
+ if (!mvbr)
+ return -ENOMEM;
+
+ mvbr->brdev = brdev;
+ mvbr->dev = DEV_FROM_BIT(bit);
+ mvbr->port = PORT_FROM_BIT(bit);
+
+ INIT_LIST_HEAD(&mvbr->list);
+ list_add_tail(&mvbr->list, &mvdst->bridges);
+ set_bit(bit, mvdst->busy_ports);
+ return 0;
+}
+
+void mv88e6xxx_dst_bridge_leave(struct dsa_switch_tree *dst,
+ struct net_device *brdev)
+{
+ struct mv88e6xxx_dst *mvdst = dst->priv;
+ struct mv88e6xxx_br *mvbr;
+ struct dsa_port *dp;
+
+ list_for_each_entry(dp, &dst->ports, list) {
+ if (dp->bridge_dev == brdev)
+ return;
+ }
+
+ list_for_each_entry(mvbr, &mvdst->bridges, list) {
+ if (mvbr->brdev == brdev) {
+ clear_bit(DEV_PORT_TO_BIT(mvbr->dev, mvbr->port),
+ mvdst->busy_ports);
+ list_del(&mvbr->list);
+ kfree(mvbr);
+ return;
+ }
+ }
+}
+
+static struct mv88e6xxx_dst *mv88e6xxx_dst_get(struct dsa_switch_tree *dst)
+{
+ struct mv88e6xxx_dst *mvdst;
+
+ if (dst->priv)
+ return dst->priv;
+
+ mvdst = kzalloc(sizeof(*mvdst), GFP_KERNEL);
+ if (!mvdst)
+ return ERR_PTR(-ENOMEM);
+
+ INIT_LIST_HEAD(&mvdst->bridges);
+
+ bitmap_set(mvdst->busy_ports,
+ DEV_PORT_TO_BIT(MV88E6XXX_G2_PVT_ADDR_DEV_TRUNK, 0),
+ MV88E6XXX_MAX_PVT_PORTS);
+
+ dst->priv = mvdst;
+ return mvdst;
+}
+
+int mv88e6xxx_dst_add_chip(struct mv88e6xxx_chip *chip)
+{
+ struct dsa_switch_tree *dst = chip->ds->dst;
+ struct mv88e6xxx_dst *mvdst;
+
+ mvdst = mv88e6xxx_dst_get(dst);
+ if (IS_ERR(mvdst))
+ return PTR_ERR(mvdst);
+
+ bitmap_set(mvdst->busy_ports, DEV_PORT_TO_BIT(chip->ds->index, 0),
+ MV88E6XXX_MAX_PVT_PORTS);
+ return 0;
+}
diff --git a/drivers/net/dsa/mv88e6xxx/dst.h b/drivers/net/dsa/mv88e6xxx/dst.h
new file mode 100644
index 000000000000..3845a19192ef
--- /dev/null
+++ b/drivers/net/dsa/mv88e6xxx/dst.h
@@ -0,0 +1,12 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+
+#ifndef _MV88E6XXX_DST_H
+#define _MV88E6XXX_DST_H
+
+int mv88e6xxx_dst_bridge_join(struct dsa_switch_tree *dst,
+ struct net_device *brdev);
+void mv88e6xxx_dst_bridge_leave(struct dsa_switch_tree *dst,
+ struct net_device *brdev);
+int mv88e6xxx_dst_add_chip(struct mv88e6xxx_chip *chip);
+
+#endif /* _MV88E6XXX_DST_H */
diff --git a/include/net/dsa.h b/include/net/dsa.h
index 77d4df819299..c01e74d6e134 100644
--- a/include/net/dsa.h
+++ b/include/net/dsa.h
@@ -172,6 +172,11 @@ struct dsa_switch_tree {
*/
struct net_device **lags;
unsigned int lags_len;
+
+ /* Give the switch driver somewhere to hang its tree-wide
+ * private data structure.
+ */
+ void *priv;
};
#define dsa_lags_foreach_id(_id, _dst) \
--
2.25.1
Powered by blists - more mailing lists