netdev - Re: [PATCH net-next v2 10/10] bnxt_en: Implement .ndo_features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 26 Apr 2021 10:09:29 -0700
From:   Michael Chan <michael.chan@...adcom.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     David Miller <davem@...emloft.net>,
        Netdev <netdev@...r.kernel.org>,
        Andrew Gospodarek <gospo@...adcom.com>
Subject: Re: [PATCH net-next v2 10/10] bnxt_en: Implement .ndo_features_check().

On Mon, Apr 26, 2021 at 10:00 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Mon, 26 Apr 2021 09:45:17 -0700 Michael Chan wrote:
> > On Mon, Apr 26, 2021 at 9:35 AM Michael Chan <michael.chan@...adcom.com> wrote:
> > > On Mon, Apr 26, 2021 at 9:29 AM Jakub Kicinski <kuba@...nel.org> wrote:
> > > > On Sun, 25 Apr 2021 13:45:27 -0400 Michael Chan wrote:
> > > > This should have been "features & ~(CSUM | GSO)" if you actually
> > > > accepted my feedback.
> >
> > Sorry, hit send too early.  If it is not UDP, it could be GRE or IP
> > over IP for example, right?  Why do we need to turn off offload?
>
> All supported protocols can be included in the allow list.
> That's one of the costs of NETIF_F_IP_CSUM, the driver needs
> to make sure the device can understand the packet.

Only UDP encapsulations have the 2 port limitations.  The rest are supported.

>
> > > I mentioned extension headers as an example,
> >
> > Extension headers (Geneve for example) are supported.
>
> I thought the Geneve things were called options. I meant IPv6 extension
> headers, which the device may also support, but then the right thing to
> do is something like a call to ipv6_skip_exthdr() to retrieve the L4
> proto.

You're right and I misunderstood you.  I will double check for ipv6
extension headers support and will send a follow up patch.  Thanks.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)