netdev - Re: [PATCH] libbpf: export inline helpers as symbols for xsk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzaDbVpLvbOnkTKtzHVGq74TfBprLuZ6fJtYqJ+jFZN+Gw@mail.gmail.com>
Date:   Mon, 26 Apr 2021 16:20:04 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Kumar Kartikeya Dwivedi <memxor@...il.com>
Cc:     bpf <bpf@...r.kernel.org>, Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        Björn Töpel <bjorn@...nel.org>,
        Magnus Karlsson <magnus.karlsson@...el.com>,
        Jonathan Lemon <jonathan.lemon@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Jesper Dangaard Brouer <brouer@...hat.com>,
        Toke Høiland-Jørgensen <toke@...hat.com>,
        Networking <netdev@...r.kernel.org>
Subject: Re: [PATCH] libbpf: export inline helpers as symbols for xsk

On Mon, Apr 26, 2021 at 1:22 PM Kumar Kartikeya Dwivedi
<memxor@...il.com> wrote:
>
> This helps people writing language bindings to not have to rewrite C
> wrappers for inline functions in the headers. We force inline the
> definition from the header for C and C++ consumers, but also export a
> symbol in the library for others. This keeps the performance
> advantages similar to using static inline, while also allowing tools
> like Rust's bindgen to generate wrappers for the functions.
>
> Also see
> https://lore.kernel.org/bpf/CAJ8uoz0QqR97qEYYK=VVCE9A=V=k2tKnH6wNM48jeak2RAmL0A@mail.gmail.com/
> for some context.
>
> Also see https://github.com/xdp-project/xdp-tools/pull/97 for more
> discussion on the same.
>
> extern inline is used as it's slightly better since it warns when an
> inline definition is missing.
>
> The fvisibility attribute goes on the inline definition, as essentially
> it acts as a declaration for the function, while the extern inline
> declaration ends up acting as a definition.
>
> Signed-off-by: Kumar Kartikeya Dwivedi <memxor@...il.com>
> ---

xsk is moving into libxdp, why not do this there, instead of exporting
a lot of symbols that we'll be deprecating very soon. It will also
incentivise customers to make a move more promptly.

Bjorn, Magnus, what's the status of libxsk in libxdp?

>  tools/lib/bpf/libbpf.map | 16 ++++++++++++++
>  tools/lib/bpf/xsk.c      | 24 +++++++++++++++++++++
>  tools/lib/bpf/xsk.h      | 45 +++++++++++++++++++++++-----------------
>  3 files changed, 66 insertions(+), 19 deletions(-)
>

[...]