netdev - Re: [PATCHv5 bpf-next 0/7] bpf: Tracing and lsm programs re-attach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQ+D5ery27Qkswwn2z9aouiK3+F48hAHZd854sHwb=hRvg@mail.gmail.com>
Date:   Sun, 25 Apr 2021 21:14:31 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Jiri Olsa <jolsa@...nel.org>, Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andriin@...com>,
        Network Development <netdev@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>, Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...omium.org>,
        Toke Høiland-Jørgensen <toke@...hat.com>,
        Julia Lawall <julia.lawall@...ia.fr>
Subject: Re: [PATCHv5 bpf-next 0/7] bpf: Tracing and lsm programs re-attach

On Thu, Apr 15, 2021 at 11:56 PM Jiri Olsa <jolsa@...hat.com> wrote:
>
> On Thu, Apr 15, 2021 at 04:45:24PM -0700, Alexei Starovoitov wrote:
> > On Wed, Apr 14, 2021 at 12:52 PM Jiri Olsa <jolsa@...nel.org> wrote:
> > >
> > > hi,
> > > while adding test for pinning the module while there's
> > > trampoline attach to it, I noticed that we don't allow
> > > link detach and following re-attach for trampolines.
> > > Adding that for tracing and lsm programs.
> > >
> > > You need to have patch [1] from bpf tree for test module
> > > attach test to pass.
> > >
> > > v5 changes:
> > >   - fixed missing hlist_del_init change
> > >   - fixed several ASSERT calls
> > >   - added extra patch for missing ';'
> > >   - added ASSERT macros to lsm test
> > >   - added acks
> >
> > It doesn't work:
>
> hi,
> I got the same warning when running test without the
> patch [1] I mentioned:
>   861de02e5f3f bpf: Take module reference for trampoline in module
>
> I still don't see it in bpf-next/master

Finally applied to bpf-next.
Thank you and sorry for the delay.