netdev - Re: [PATCH bpf-next 3/5] selftests/bpf: fix BPF_CORE_READ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACAyw98yy6K_TPRs2Q7E8FbW2tocfFWRgRRoEM15NTBcRFV2+Q@mail.gmail.com>
Date:   Mon, 26 Apr 2021 09:10:22 +0100
From:   Lorenz Bauer <lmb@...udflare.com>
To:     Andrii Nakryiko <andrii@...nel.org>
Cc:     bpf <bpf@...r.kernel.org>, Networking <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH bpf-next 3/5] selftests/bpf: fix BPF_CORE_READ_BITFIELD() macro

On Sat, 24 Apr 2021 at 00:36, Andrii Nakryiko <andrii@...nel.org> wrote:
>
> Fix BPF_CORE_READ_BITFIELD() macro used for reading CO-RE-relocatable
> bitfields. Missing breaks in a switch caused 8-byte reads always. This can
> confuse libbpf because it does strict checks that memory load size corresponds
> to the original size of the field, which in this case quite often would be
> wrong.

Acked-by: Lorenz Bauer <lmb@...udflare.com>

-- 
Lorenz Bauer  |  Systems Engineer
6th Floor, County Hall/The Riverside Building, SE1 7PB, UK

www.cloudflare.com