netdev - RE: [net-next, v2, 3/7] net: dsa: free skb->cb usage in core driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM7PR04MB688558223DE6163913985B3DF8419@AM7PR04MB6885.eurprd04.prod.outlook.com>
Date:   Tue, 27 Apr 2021 04:26:13 +0000
From:   "Y.b. Lu" <yangbo.lu@....com>
To:     Richard Cochran <richardcochran@...il.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Vladimir Oltean <vladimir.oltean@....com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Jonathan Corbet <corbet@....net>,
        Kurt Kanzenbach <kurt@...utronix.de>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        "UNGLinuxDriver@...rochip.com" <UNGLinuxDriver@...rochip.com>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [net-next, v2, 3/7] net: dsa: free skb->cb usage in core driver



> -----Original Message-----
> From: Richard Cochran <richardcochran@...il.com>
> Sent: 2021年4月26日 21:39
> To: Y.b. Lu <yangbo.lu@....com>
> Cc: netdev@...r.kernel.org; Vladimir Oltean <vladimir.oltean@....com>;
> David S . Miller <davem@...emloft.net>; Jakub Kicinski <kuba@...nel.org>;
> Jonathan Corbet <corbet@....net>; Kurt Kanzenbach <kurt@...utronix.de>;
> Andrew Lunn <andrew@...n.ch>; Vivien Didelot <vivien.didelot@...il.com>;
> Florian Fainelli <f.fainelli@...il.com>; Claudiu Manoil
> <claudiu.manoil@....com>; Alexandre Belloni
> <alexandre.belloni@...tlin.com>; UNGLinuxDriver@...rochip.com;
> linux-doc@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: Re: [net-next, v2, 3/7] net: dsa: free skb->cb usage in core driver
> 
> On Mon, Apr 26, 2021 at 05:37:58PM +0800, Yangbo Lu wrote:
> > @@ -624,7 +623,7 @@ static netdev_tx_t dsa_slave_xmit(struct sk_buff
> *skb, struct net_device *dev)
> >
> >  	dev_sw_netstats_tx_add(dev, 1, skb->len);
> >
> > -	DSA_SKB_CB(skb)->clone = NULL;
> > +	memset(skb->cb, 0, 48);
> 
> Replace hard coded 48 with sizeof() please.

Fixed in v3.
Thank you!

> 
> Thanks,
> Richard