netdev - Re: [PATCH v2 bpf-next 0/5] CO-RE relocation selftests fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQKQ5ZddWKtEbWf16xbN-QXuLP8DZJbHg48y=RyHJ2v8EA@mail.gmail.com>
Date:   Mon, 26 Apr 2021 18:43:09 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Andrii Nakryiko <andrii@...nel.org>
Cc:     bpf <bpf@...r.kernel.org>,
        Network Development <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Kernel Team <kernel-team@...com>,
        Lorenz Bauer <lmb@...udflare.com>
Subject: Re: [PATCH v2 bpf-next 0/5] CO-RE relocation selftests fixes

On Mon, Apr 26, 2021 at 12:30 PM Andrii Nakryiko <andrii@...nel.org> wrote:
>
> Lorenz Bauer noticed that core_reloc selftest has two inverted CHECK()
> conditions, allowing failing tests to pass unnoticed. Fixing that opened up
> few long-standing (field existence and direct memory bitfields) and one recent
> failures (BTF_KIND_FLOAT relos).
>
> This patch set fixes core_reloc selftest to capture such failures reliably in
> the future. It also fixes all the newly failing tests. See individual patches
> for details.
>
> This patch set also completes a set of ASSERT_xxx() macros, so now there
> should be a very little reason to use verbose and error-prone generic CHECK()
> macro.
>
> v1->v2:
>   - updated bpf_core_fields_are_compat() comment to mention FLOAT (Lorenz).

Applied.