netdev - Re: [BISECTED] 5.12 hangs at reboot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20210427074321.callv22dm4drb2jn@gondor.apana.org.au>
Date:   Tue, 27 Apr 2021 15:43:21 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     harald@...gtun.org, johannes@...solutions.net,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [BISECTED] 5.12 hangs at reboot

Linus Torvalds <torvalds@...ux-foundation.org> wrote:
>
> At a guess, there is some other sequence that takes the rtnl lock, and
> then takes the wiphy_lock inside of it, and we have a ABBA deadlock.

The most common cause of these lockups is a stray reference on
some kind of a network object, e.g., a socket or some such.  This
then causes the underlying network device to be reference counted
and triggers a lock-up if that network device needs to be removed.

> I _hate_ that stupid rtnl lock. It's come up before. Several times.
> It's probably the most broken lock in the kernel.

Yes, it's the networking equivalent of the BKL.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt