netdev - Re: [PATCH net-next] icmp: standardize naming of RFC 8335 PROBE constants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YIgDfGZrSqQXjy54@lunn.ch>
Date:   Tue, 27 Apr 2021 14:28:44 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Andreas Roeseler <andreas.a.roeseler@...il.com>
Cc:     Stephen Hemminger <stephen@...workplumber.org>,
        netdev@...r.kernel.org, davem@...emloft.net,
        yoshfuji@...ux-ipv6.org, dsahern@...nel.org, kuba@...nel.org
Subject: Re: [PATCH net-next] icmp: standardize naming of RFC 8335 PROBE
 constants

> > You can't just remove the old constants. They have to stay there.
> > The #defines are part of the Linux API by now.
> 
> Even in the case where these constants were added less than a month ago
> (3/30/2021) and are not used elsewhere in the kernel? I agree with your
> statement in the general sense, but I thought I could get ahead of it
> in this case and update them.
> 
> For reference, they were added in commit
> 2b246b2569cd2ac6ff700d0dce56b8bae29b1842
 
You need to make this very clear in the commit message, that the code
you are changing is currently only in net-next, no released Kernels
are using these symbols, and you are not break the API.

    Andrew