netdev - Re: [PATCH v2 3/3] can-isotp: Add error message if txqueuelen is too small

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <59649e89-5788-9e1d-bae7-2bfa41666595@posteo.de>
Date:   Tue, 27 Apr 2021 13:13:13 +0000
From:   Patrick Menschel <menschel.p@...teo.de>
To:     Marc Kleine-Budde <mkl@...gutronix.de>
Cc:     Oliver Hartkopp <socketcan@...tkopp.net>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, linux-can@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/3] can-isotp: Add error message if txqueuelen is too
 small

Am 27.04.21 um 09:16 schrieb Marc Kleine-Budde:
> On 27.04.2021 05:21:49, Patrick Menschel wrote:
>> This patch adds an additional error message in
>> case that txqueuelen is set too small and
>> advices the user to increase txqueuelen.
>>
>> This is likely to happen even with small transfers if
>> txqueuelen is at default value 10 frames.
>>
>> Signed-off-by: Patrick Menschel <menschel.p@...teo.de>
>> ---
>>  net/can/isotp.c | 6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/net/can/isotp.c b/net/can/isotp.c
>> index 2075d8d9e..d08f95bfd 100644
>> --- a/net/can/isotp.c
>> +++ b/net/can/isotp.c
>> @@ -797,10 +797,12 @@ static enum hrtimer_restart isotp_tx_timer_handler(struct hrtimer *hrtimer)
>>  		can_skb_set_owner(skb, sk);
>>  
>>  		can_send_ret = can_send(skb, 1);
>> -		if (can_send_ret)
>> +		if (can_send_ret) {
>>  			pr_notice_once("can-isotp: %s: can_send_ret %pe\n",
>>  				       __func__, ERR_PTR(can_send_ret));
>> -
>> +			if (can_send_ret == -ENOBUFS)
>> +				pr_notice_once("can-isotp: tx queue is full, increasing txqueuelen may prevent this error");
> 
> I've added the missing "\n" at the end while applying the patch to
> linux-can-next/testing.
> 
> regards,
> Marc
> 
Thanks, that was sloppy of me.

Regards,
Patrick