netdev - Re: [PATCH RESEND net-next] icmp: standardize naming of RFC 8335 PROBE constants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c81da93b-a23c-67ca-c661-95548238d1e7@gmail.com>
Date:   Wed, 28 Apr 2021 09:30:33 -0600
From:   David Ahern <dsahern@...il.com>
To:     Andreas Roeseler <andreas.a.roeseler@...il.com>,
        netdev@...r.kernel.org
Cc:     davem@...emloft.net, yoshfuji@...ux-ipv6.org, dsahern@...nel.org,
        kuba@...nel.org, stephen@...workplumber.org, andrew@...n.ch
Subject: Re: [PATCH RESEND net-next] icmp: standardize naming of RFC 8335
 PROBE constants

On 4/27/21 9:36 AM, Andreas Roeseler wrote:
> The current definitions of constants for PROBE, currently defined only
> in the net-next kernel branch, are inconsistent, with
> some beginning with ICMP and others with simply EXT. This patch
> attempts to standardize the naming conventions of the constants for
> PROBE before their release into a stable Kernel, and to update the
> relevant definitions in net/ipv4/icmp.c.
> 
> Similarly, the definitions for the code field (previously
> ICMP_EXT_MAL_QUERY, etc) use the same prefixes as the type field. This
> patch adds _CODE_ to the prefix to clarify the distinction of these
> constants.
> 
> Signed-off-by: Andreas Roeseler <andreas.a.roeseler@...il.com>
> ---
>  include/uapi/linux/icmp.h | 28 ++++++++++++++--------------
>  net/ipv4/icmp.c           | 16 ++++++++--------
>  2 files changed, 22 insertions(+), 22 deletions(-)
> 

Acked-by: David Ahern <dsahern@...nel.org>