netdev - [PATCH] phy: nxp-c45-tja11xx: fix boolconv.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 29 Apr 2021 00:07:28 +0800
From:   kernel test robot <lkp@...el.com>
To:     "Radu Pirea (NXP OSS)" <radu-nicolae.pirea@....nxp.com>,
        andrew@...n.ch, hkallweit1@...il.com, linux@...linux.org.uk,
        davem@...emloft.net, kuba@...nel.org, richardcochran@...il.com
Cc:     kbuild-all@...ts.01.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        "Radu Pirea (NXP OSS)" <radu-nicolae.pirea@....nxp.com>
Subject: [PATCH] phy: nxp-c45-tja11xx: fix boolconv.cocci warnings

From: kernel test robot <lkp@...el.com>

drivers/net/phy/nxp-c45-tja11xx.c:269:25-30: WARNING: conversion to bool not needed here

 Remove unneeded conversion to bool

Semantic patch information:
 Relational and logical operators evaluate to bool,
 explicit conversion is overly verbose and unneeded.

Generated by: scripts/coccinelle/misc/boolconv.cocci

CC: Radu Pirea (NXP OSS) <radu-nicolae.pirea@....nxp.com>
Reported-by: kernel test robot <lkp@...el.com>
Signed-off-by: kernel test robot <lkp@...el.com>
---

url:    https://github.com/0day-ci/linux/commits/Radu-Pirea-NXP-OSS/Add-PTP-support-for-TJA1103/20210428-203250
base:    a5fb44b89809a00cfb85997529d8430ed0759ea5

 nxp-c45-tja11xx.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/net/phy/nxp-c45-tja11xx.c
+++ b/drivers/net/phy/nxp-c45-tja11xx.c
@@ -266,7 +266,7 @@ static int nxp_c45_ptp_adjfine(struct pt
 	u64 subns_inc_val;
 	bool inc;
 
-	inc = ppb >= 0 ? true : false;
+	inc = ppb >= 0;
 	ppb = abs(ppb);
 
 	subns_inc_val = PPM_TO_SUBNS_INC(ppb);