netdev - Re: [PATCH v2] kbuild: replace LANG=C with LC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YIudYzwMq18AS8nB@kroah.com>
Date:   Fri, 30 Apr 2021 08:02:11 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Masahiro Yamada <masahiroy@...nel.org>
Cc:     linux-kbuild@...r.kernel.org,
        Michael Ellerman <mpe@...erman.id.au>,
        Matthias Maennich <maennich@...gle.com>,
        Matthieu Baerts <matthieu.baerts@...sares.net>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Mat Martineau <mathew.j.martineau@...ux.intel.com>,
        Paul Mackerras <paulus@...ba.org>,
        Shuah Khan <shuah@...nel.org>, linux-kernel@...r.kernel.org,
        linux-kselftest@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        mptcp@...ts.linux.dev, netdev@...r.kernel.org
Subject: Re: [PATCH v2] kbuild: replace LANG=C with LC_ALL=C

On Fri, Apr 30, 2021 at 10:56:27AM +0900, Masahiro Yamada wrote:
> LANG gives a weak default to each LC_* in case it is not explicitly
> defined. LC_ALL, if set, overrides all other LC_* variables.
> 
>   LANG  <  LC_CTYPE, LC_COLLATE, LC_MONETARY, LC_NUMERIC, ...  <  LC_ALL
> 
> This is why documentation such as [1] suggests to set LC_ALL in build
> scripts to get the deterministic result.
> 
> LANG=C is not strong enough to override LC_* that may be set by end
> users.
> 
> [1]: https://reproducible-builds.org/docs/locales/
> 
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> Acked-by: Michael Ellerman <mpe@...erman.id.au> (powerpc)
> Reviewed-by: Matthias Maennich <maennich@...gle.com>
> Acked-by: Matthieu Baerts <matthieu.baerts@...sares.net> (mptcp)

Reviewed-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>