netdev - Re: [PATCH net-next 0/4] MT7530 interrupt support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YIv28APpOP9tnuO+@lunn.ch>
Date:   Fri, 30 Apr 2021 14:24:16 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     DENG Qingfang <dqfext@...il.com>
Cc:     David Miller <davem@...emloft.net>, f.fainelli@...il.com,
        hkallweit1@...il.com, kuba@...nel.org, Landen.Chao@...iatek.com,
        matthias.bgg@...il.com, linux@...linux.org.uk,
        sean.wang@...iatek.com, vivien.didelot@...il.com,
        olteanv@...il.com, robh+dt@...nel.org, linus.walleij@...aro.org,
        gregkh@...uxfoundation.org, sergio.paracuellos@...il.com,
        linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        linux-staging@...ts.linux.dev, devicetree@...r.kernel.org,
        netdev@...r.kernel.org, weijie.gao@...iatek.com,
        gch981213@...il.com, opensource@...rst.com,
        frank-w@...lic-files.de, tglx@...utronix.de, maz@...nel.org
Subject: Re: [PATCH net-next 0/4] MT7530 interrupt support

On Fri, Apr 30, 2021 at 10:38:39AM +0800, DENG Qingfang wrote:
> On Thu, Apr 29, 2021 at 05:08:15PM -0700, David Miller wrote:
> > 
> > Please fix this:
> > 
> > error: the following would cause module name conflict:
> >   drivers/net/phy/mediatek.ko
> >   drivers/usb/musb/mediatek.ko
> 
> So I still have to rename the PHY driver..
> Andrew, what is your suggestion? Is mediatek_phy.c okay?

mediatek_phy.c gets you into trouble with the generic PHY drivers.
Most Ethernet PHY drivers have the model number in the file name. Does
the PHY have its own name/numbering, or is it always considered part
of the switch?  If the PHY has an identity of its own, use
that. Otherwise maybe mediatek75xx.c?

      Andrew