netdev - Re: [PATCH net-next 4/4] net: hns3: disable phy loopback setting in hclge_mac_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YIv9d9CHvWAtbqJE@lunn.ch>
Date:   Fri, 30 Apr 2021 14:52:07 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Huazhong Tan <tanhuazhong@...wei.com>
Cc:     davem@...emloft.net, kuba@...nel.org, netdev@...r.kernel.org,
        salil.mehta@...wei.com, yisen.zhuang@...wei.com,
        huangdaode@...wei.com, linuxarm@...neuler.org, linuxarm@...wei.com,
        Yufeng Mo <moyufeng@...wei.com>
Subject: Re: [PATCH net-next 4/4] net: hns3: disable phy loopback setting in
 hclge_mac_start_phy

On Fri, Apr 30, 2021 at 05:06:22PM +0800, Huazhong Tan wrote:
> From: Yufeng Mo <moyufeng@...wei.com>
> 
> If selftest and reset are performed at the same time, the phy
> loopback setting may be still in enable state after the reset,
> and device cannot link up. So fix this issue by disabling phy
> loopback before phy_start().

This sounds like a generic problem, not specific to your
driver. Please look at solving this within phy_start().

	Andrew