netdev - Re: [PATCH net] rsi: Add a NULL check in rsi_core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <573f85365f81b2505c90fd6e3e003faf48067abe.camel@sipsolutions.net>
Date:   Fri, 30 Apr 2021 16:59:00 +0200
From:   Johannes Berg <johannes@...solutions.net>
To:     wangyunjian <wangyunjian@...wei.com>, kuba@...nel.org,
        davem@...emloft.net
Cc:     amitkarwar@...il.com, siva8118@...il.com,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        dingxiaoxiong@...wei.com
Subject: Re: [PATCH net] rsi: Add a NULL check in rsi_core_xmit

On Fri, 2021-04-30 at 22:46 +0800, wangyunjian wrote:
> From: Yunjian Wang <wangyunjian@...wei.com>
> 
> The skb may be NULL in rsi_core_xmit().

How so?

Static checkers are good. Coverity is one of the better ones, in my
experience. But blindly believing static checkers still isn't good.

I see why the static checker is confused, but really, _you_ should have
done that work, not me.

johannes