netdev - Re: A problem with "ip=..." ipconfig and Atheros alx driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <608C3B2C.8040005@gmail.com>
Date:   Fri, 30 Apr 2021 20:15:24 +0300
From:   Nikolai Zhubr <zhubr.2@...il.com>
To:     Johannes Berg <johannes@...solutions.net>
CC:     Chris Snook <chris.snook@...il.com>, netdev@...r.kernel.org
Subject: Re: A problem with "ip=..." ipconfig and Atheros alx driver.

Hi Johannes,

30.04.2021 15:08, Johannes Berg:
>> rtnl_unlock(). Hence this delay and timeout.
>
> Fun. But we can just do it synchronously?
>
> https://p.sipsolutions.net/e4f076ed1b4c8a78.txt

Wow, that was quick! Thanks! However, unfortunately this patch still 
does not quite fix the problem. Although alx_check_link() now gets 
called synchronously at open, it somehow does not pass below the "if 
(old_speed == hw->link_speed) return" line here. I'd guess it is because 
the chip is not yet able to report meaningfull values immediately after 
initialization. The result is still the same: 120 seconds timeout 
happens, then the "eth0: NIC Up: 1 Gbps Full" message appears 
immediately and all is fine after that.
I'll do some more testing later today.

Thank you,

Regards,
Nikolai

>
> johannes
>
>