netdev - Re: [iproute2-next] seg6: add counters support for SRv6 Behaviors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <44091450-1b0d-664f-07e6-7eff48ca92c7@gmail.com>
Date:   Sat, 1 May 2021 09:14:08 -0600
From:   David Ahern <dsahern@...il.com>
To:     Paolo Lungaroni <paolo.lungaroni@...roma2.it>,
        David Ahern <dsahern@...nel.org>, netdev@...r.kernel.org
Cc:     Jakub Kicinski <kuba@...nel.org>,
        Stephen Hemminger <stephen@...workplumber.org>,
        Stefano Salsano <stefano.salsano@...roma2.it>,
        Ahmed Abdelsalam <ahabdels.dev@...il.com>,
        Andrea Mayer <andrea.mayer@...roma2.it>
Subject: Re: [iproute2-next] seg6: add counters support for SRv6 Behaviors

On 4/27/21 9:55 AM, Paolo Lungaroni wrote:
> @@ -932,6 +997,11 @@ static int parse_encap_seg6local(struct rtattr *rta, size_t len, int *argcp,
>  			if (!oif)
>  				exit(nodev(*argv));
>  			ret = rta_addattr32(rta, len, SEG6_LOCAL_OIF, oif);
> +		} else if (strcmp(*argv, "count") == 0) {
> +			if (counters_ok++)
> +				duparg2("count", *argv);
> +			ret = seg6local_fill_counters(rta, len,
> +						      SEG6_LOCAL_COUNTERS);
>  		} else if (strcmp(*argv, "srh") == 0) {
>  			NEXT_ARG();
>  			if (srh_ok++)
> 

change looks fine. Can you send a v2 with the help and route.8 man page
updates? Thanks,