netdev - Re: [PATCHv2 net 2/3] Revert "sctp: Fix bundling of SHUTDOWN with COOKIE-ACK"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <HE1PR0702MB38180256C324E2C9A234AFA6EC5D9@HE1PR0702MB3818.eurprd07.prod.outlook.com>
Date:   Sat, 1 May 2021 16:56:29 +0000
From:   "Leppanen, Jere (Nokia - FI/Espoo)" <jere.leppanen@...ia.com>
To:     Xin Long <lucien.xin@...il.com>,
        network dev <netdev@...r.kernel.org>,
        "linux-sctp@...r.kernel.org" <linux-sctp@...r.kernel.org>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
        "Sverdlin, Alexander (Nokia - DE/Ulm)" <alexander.sverdlin@...ia.com>
Subject: Re: [PATCHv2 net 2/3] Revert "sctp: Fix bundling of SHUTDOWN with
 COOKIE-ACK"

On Fri, 30 Apr 2021, Xin Long wrote:

> This can be reverted as shutdown and cookie_ack chunk are using the
> same asoc since the last patch.
>
> This reverts commit 145cb2f7177d94bc54563ed26027e952ee0ae03c.

I think this should not be reverted. Without it, SHUTDOWN would
get its transport from sctp_assoc_choose_alter_transport(), which
could be different from the COOKIE-ACK transport, which would
prevent bundling.

>
> Signed-off-by: Xin Long <lucien.xin@...il.com>
> Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
> ---
> net/sctp/sm_statefuns.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/net/sctp/sm_statefuns.c b/net/sctp/sm_statefuns.c
> index 30cb946..e8ccc4e 100644
> --- a/net/sctp/sm_statefuns.c
> +++ b/net/sctp/sm_statefuns.c
> @@ -1892,7 +1892,7 @@ static enum sctp_disposition sctp_sf_do_dupcook_a(
>                */
>               sctp_add_cmd_sf(commands, SCTP_CMD_REPLY, SCTP_CHUNK(repl));
>               return sctp_sf_do_9_2_start_shutdown(net, ep, asoc,
> -                                                  SCTP_ST_CHUNK(0), repl,
> +                                                  SCTP_ST_CHUNK(0), NULL,
>                                                    commands);
>       } else {
>               sctp_add_cmd_sf(commands, SCTP_CMD_NEW_STATE,
> @@ -5536,7 +5536,7 @@ enum sctp_disposition sctp_sf_do_9_2_start_shutdown(
>        * in the Cumulative TSN Ack field the last sequential TSN it
>        * has received from the peer.
>        */
> -     reply = sctp_make_shutdown(asoc, arg);
> +     reply = sctp_make_shutdown(asoc, NULL);
>       if (!reply)
>               goto nomem;
>
> @@ -6134,7 +6134,7 @@ enum sctp_disposition sctp_sf_autoclose_timer_expire(
>       disposition = SCTP_DISPOSITION_CONSUME;
>       if (sctp_outq_is_empty(&asoc->outqueue)) {
>               disposition = sctp_sf_do_9_2_start_shutdown(net, ep, asoc, type,
> -                                                         NULL, commands);
> +                                                         arg, commands);
>       }
>
>       return disposition;
> -- 
> 2.1.0