netdev - Re: [PATCH v2 net-next] net/mlx5: net/mlx5: Fix some error messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YI5Xxw9R4DqEQ1uv@unreal>
Date:   Sun, 2 May 2021 10:41:59 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Saeed Mahameed <saeedm@...dia.com>,
        "David S. Miller" <dddavem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Yevgeny Kliteynik <kliteyn@...dia.com>, netdev@...r.kernel.org,
        linux-rdma@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH v2 net-next] net/mlx5: net/mlx5: Fix some error messages

On Thu, Apr 29, 2021 at 02:06:04PM +0300, Dan Carpenter wrote:
> This code was using IS_ERR() instead of PTR_ERR() so it prints 1 instead
> of the correct error code.  Even better would be to use %pe which prints
> out the name of the error, as in "ENOMEM", "EINVAL" etc.
> 
> Fixes: 25cb31768042 ("net/mlx5: E-Switch, Improve error messages in term table creation")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> ---
> v2:  Use %pe instead of %ld.
> 
> Leon says this goes through netdev instead of the RDMA tree.

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...dia.com>