netdev - Re: [PATCH ethtool-next v2 5/7] ethtool: add nlchk for redirecting to netlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210502213931.iqb6zyn6nlkiy7ke@lion.mk-sys.cz>
Date:   Sun, 2 May 2021 23:39:31 +0200
From:   Michal Kubecek <mkubecek@...e.cz>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, idosch@...sch.org
Subject: Re: [PATCH ethtool-next v2 5/7] ethtool: add nlchk for redirecting
 to netlink

On Thu, Apr 22, 2021 at 08:40:48AM -0700, Jakub Kicinski wrote:
> To support commands which differ from the ioctl implementation
> add a new callback which can check if the arguments on the command
> line indicate that the request should be sent over netlink.
> The decision should be inferred from the arguments, rather
> than an explicit --netlink argument.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

This breaks build with --disable-netlink, the !ETHTOOL_ENABLE_NETLINK
version of netlink_run_handler() needs to be updated as well.

Other than this and the two minor nitpicks, the series looks good to me.

Michal

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)