netdev - Re: [PATCH ethtool-next v2 7/7] netlink: stats: add on --all-groups option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210503161115.3vjsn5uxm5wuj55k@lion.mk-sys.cz>
Date:   Mon, 3 May 2021 18:11:15 +0200
From:   Michal Kubecek <mkubecek@...e.cz>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, idosch@...sch.org,
        Ido Schimmel <idosch@...dia.com>
Subject: Re: [PATCH ethtool-next v2 7/7] netlink: stats: add on --all-groups
 option

On Mon, May 03, 2021 at 08:59:01AM -0700, Jakub Kicinski wrote:
> On Sun, 2 May 2021 23:36:40 +0200 Michal Kubecek wrote:
> > > Add a switch for querying all statistic groups available
> > > in the kernel.
> > > 
> > > To reject --groups and --all-groups being specified
> > > for one request add a concept of "parameter equivalency"  
> > 
> > I like the idea but the term "equivalency" may be a bit misleading.
> > Maybe "alternatives" would express the relation better.
> 
> Thanks for the review! I take it you mean to rename the code as well?
> Not just the commit message?

Yes, if we agree that the term is a bit misleading, I would rather see
the struct member renamed.

Michal