netdev - Re: [PATCH net-next v2] net/mlx5e: Fix uninitialised struct field moder.comps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 4 May 2021 10:27:13 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     wangyunjian <wangyunjian@...wei.com>
Cc:     kuba@...nel.org, davem@...emloft.net, saeedm@...dia.com,
        netdev@...r.kernel.org, dingxiaoxiong@...wei.com
Subject: Re: [PATCH net-next v2] net/mlx5e: Fix uninitialised struct field
 moder.comps

On Tue, Apr 20, 2021 at 03:00:26PM +0800, wangyunjian wrote:
> From: Yunjian Wang <wangyunjian@...wei.com>
> 
> The 'comps' struct field in 'moder' is not being initialized in
> mlx5e_get_def_rx_moderation() and mlx5e_get_def_tx_moderation().
> So initialize 'moder' to zero to avoid the issue.
> 
> Addresses-Coverity: ("Uninitialized scalar variable")
> Signed-off-by: Yunjian Wang <wangyunjian@...wei.com>
> ---
> v2: update mlx5e_get_def_tx_moderation() also needs fixing

Actually grep other all "struct dim_cq_moder ...;" declarations shows
many places like this. Are you going to change them too?

Thanks